use default settings for timeline deck width #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
cosmicBboy
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
eapolinario
previously approved these changes
Jul 18, 2023
pingsutw
previously approved these changes
Jul 18, 2023
pingsutw
approved these changes
Jul 18, 2023
fg91
pushed a commit
that referenced
this pull request
Aug 15, 2023
* use default settings for timeline deck width Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix test Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Use default width settings for timeline deck
Type
Are all requirements met?
Complete description
Before this change, the timeline deck will occupy 1400px of width on any of the mediums it's rendered in. For example, if we turn on execution on some of the flytesnacks docs pages, we get:
This PR will just use the default plotly settings, which will occupy the maximum width inside whatever container the plotly graphs are contained in.
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/