Add type transformer for datetime.date #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: troychiu <y.troychiu@gmail.com>
troychiu
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
pingsutw
approved these changes
Aug 11, 2023
|
Congrats on merging your first pull request! 🎉 |
fg91
pushed a commit
that referenced
this pull request
Aug 15, 2023
Signed-off-by: troychiu <y.troychiu@gmail.com>
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Oct 3, 2023
Signed-off-by: troychiu <y.troychiu@gmail.com> Signed-off-by: Future Outlier <eric901201@gmai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
As title
Type
Are all requirements met?
Complete description
Hi community,
This is my first pr in Flyte. I have followed the contribution guide and if there is anything I missed, feel free to leave a comment.
I added a simple transformer for datetime.date.
The
to_literal_transformerconvert datetime.date to datetime.datetime.The
from_literal_transformerconvert datetime.datetime to datetime.date.Also, I add corresponding tests to test_type_engine.
Tracking Issue
flyteorg/flyte#3026
Follow-up issue
Add datetime.date to https://docs.flyte.org/projects/cookbook/en/latest/auto_examples/type_system/flyte_python_types.html#flytekit-to-flyte-type-mapping