Add more clear error message when fetching secrets #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yue Shang <s.yue3074@gmail.com>
ysysys3074
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
ByronHsu
previously approved these changes
Sep 22, 2023
pingsutw
previously approved these changes
Sep 23, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1847 +/- ##
===========================================
- Coverage 71.03% 20.13% -50.90%
===========================================
Files 336 337 +1
Lines 30798 32427 +1629
Branches 5589 5857 +268
===========================================
- Hits 21876 6530 -15346
- Misses 8375 25731 +17356
+ Partials 547 166 -381
☔ View full report in Codecov by Sentry. |
Signed-off-by: Yue Shang <s.yue3074@gmail.com>
pingsutw
approved these changes
Sep 23, 2023
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Oct 3, 2023
* add more clear error message when fetch secrets Signed-off-by: Yue Shang <s.yue3074@gmail.com> * fix format Signed-off-by: Yue Shang <s.yue3074@gmail.com> --------- Signed-off-by: Yue Shang <s.yue3074@gmail.com> Signed-off-by: Future Outlier <eric901201@gmai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
User gets confused as error message is missing useful prompts when they did not add secret_requests in task config to get secrets, this PR adds more clear error message.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/