Label request_failure metric with error_code #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario and
cosmicBboy
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1862 +/- ##
==========================================
+ Coverage 54.97% 55.02% +0.04%
==========================================
Files 296 296
Lines 22231 22218 -13
Branches 2167 2172 +5
==========================================
+ Hits 12222 12225 +3
+ Misses 9860 9844 -16
Partials 149 149
☔ View full report in Codecov by Sentry. |
wild-endeavor
approved these changes
Oct 2, 2023
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Oct 3, 2023
--------- Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Future Outlier <eric901201@gmai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Label request_failure metric with error_code to distinguish failure from an error.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#3936
Follow-up issue
NA