Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name field is incorrect assigned #1874

Merged
merged 2 commits into from Oct 6, 2023
Merged

Name field is incorrect assigned #1874

merged 2 commits into from Oct 6, 2023

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Oct 5, 2023

TL;DR

pyflyte run --remote --name f78b0145-016a-44d8-bac0-fffa2e722f9c test2.py wf --n 10

Name is not used correctly

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (67b2169) 55.01% compared to head (656e9fb) 55.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1874   +/-   ##
=======================================
  Coverage   55.01%   55.02%           
=======================================
  Files         296      296           
  Lines       22216    22218    +2     
  Branches     2172     2172           
=======================================
+ Hits        12223    12225    +2     
  Misses       9844     9844           
  Partials      149      149           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wild-endeavor
wild-endeavor previously approved these changes Oct 6, 2023
Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to keep the print?

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
@kumare3 kumare3 merged commit c413570 into master Oct 6, 2023
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants