Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flyteagent image build #1906

Merged
merged 1 commit into from Oct 20, 2023
Merged

Fix flyteagent image build #1906

merged 1 commit into from Oct 20, 2023

Conversation

eapolinario
Copy link
Collaborator

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc9d26b) 55.07% compared to head (b756ddc) 54.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1906      +/-   ##
==========================================
- Coverage   55.07%   54.86%   -0.22%     
==========================================
  Files         301      298       -3     
  Lines       22453    22348     -105     
  Branches     3371     3371              
==========================================
- Hits        12366    12261     -105     
  Misses       9922     9922              
  Partials      165      165              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 1b5692a into master Oct 20, 2023
70 of 71 checks passed
ringohoffman pushed a commit to ringohoffman/flytekit that referenced this pull request Nov 24, 2023
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants