-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vscode decorator #2018
Update vscode decorator #2018
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2018 +/- ##
==========================================
- Coverage 85.98% 84.87% -1.12%
==========================================
Files 308 258 -50
Lines 22946 20763 -2183
Branches 3468 3475 +7
==========================================
- Hits 19731 17622 -2109
+ Misses 2615 2536 -79
- Partials 600 605 +5 ☔ View full report in Codecov by Sentry. |
else: | ||
# If self.func is None, it means decorator was called with arguments. | ||
# Therefore, __call__ received the actual function to be decorated. | ||
# We return a new instance of ClassDecorator with the function and stored arguments. | ||
return self.__class__(args[0], **self.decorator_kwargs) | ||
|
||
@abstractmethod | ||
def _wrap_call(self, *args, **kwargs): | ||
def execute(self, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
abstractmethod instead of NotImplementedError?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Kevin Su <pingsutw@apache.org>
flyin python 3.8 tests are failing: https://github.com/flyteorg/flytekit/actions/runs/7215520972/job/19660153192?pr=2018 |
Why are the changes needed?
Failed to run the task with vscode decorator locally.
What changes were proposed in this pull request?
extract_task_module
, so we are able to get the task module and name fromClassDecorator
_wrap_call
to executeHow was this patch tested?
Run a task with vscode decorator locally
Setup process
Screenshots
Check all the applicable boxes