Separate agent from pyflyte serve #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com>
Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com>
chaohengstudent
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2019 +/- ##
=======================================
Coverage 86.22% 86.22%
=======================================
Files 320 320
Lines 23531 23531
Branches 3464 3464
=======================================
Hits 20289 20289
Misses 2650 2650
Partials 592 592 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com>
3 tasks
Signed-off-by: Future Outlier <eric901201@gmai.com>
|
I think so please create docs and comments |
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Dec 12, 2023
* Separate agent from pyflyte serve. Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com> * removed unused serve help message. Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com> * fix typo. Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com> * update dockerfile of agent. Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com> * remove agent dockerfile apt cache Signed-off-by: Future Outlier <eric901201@gmai.com> --------- Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com> Signed-off-by: Future Outlier <eric901201@gmai.com> Co-authored-by: Future Outlier <eric901201@gmai.com> Signed-off-by: Future Outlier <eric901201@gmai.com>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* Separate agent from pyflyte serve. Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com> * removed unused serve help message. Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com> * fix typo. Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com> * update dockerfile of agent. Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com> * remove agent dockerfile apt cache Signed-off-by: Future Outlier <eric901201@gmai.com> --------- Signed-off-by: Chao-Heng Lee <chaohengstudent@gmail.com> Signed-off-by: Future Outlier <eric901201@gmai.com> Co-authored-by: Future Outlier <eric901201@gmai.com> Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#3936
Why are the changes needed?
We might have the demands of using
pyflyte serve <other service>So separate agent as one of the serve group's commands.
What changes were proposed in this pull request?
Make
serveas group and moveagentas one of the group's commands.Screenshots
Check all the applicable boxes