-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds conda support to envd plugin #2020
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2020 +/- ##
==========================================
+ Coverage 85.76% 85.78% +0.01%
==========================================
Files 313 313
Lines 23426 23447 +21
Branches 3510 3510
==========================================
+ Hits 20092 20114 +22
Misses 2727 2727
+ Partials 607 606 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you resolve the merge conflict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasjpfan unit tests in envd-plugin are failing
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
d19ad0c
to
456e6ac
Compare
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: Future-Outlier <eric901201@gmai.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Why are the changes needed?
This PR adds
conda
support toenvd
. This makes it simple to use Nvidia's runtime environment for PyTorch:which is inline with PyTorch's docs.
Furthermore, I do not think it is possible to install
cuda=12.1
withenvd
. Usingconda
allows forcuda=12.1
and makes it simple to switch between Nvidia runtimes.What changes were proposed in this pull request?
This PR adds
conda_packages
andconda_channels
toImageSpec
to specific the conda packages and channels.How was this patch tested?
I added a unit test to check the expected behavior.
Docs link