Add various executions phases which are available in flyteidl, but not in flytekit #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2023 15:40
…t not in flytekit Signed-off-by: Maarten de Jong <mdejong@blackshark.ai>
Signed-off-by: Maarten de Jong <mdejong@blackshark.ai>
mdjong1
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
mdjong1
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2022 +/- ##
===========================================
- Coverage 86.22% 63.19% -23.03%
===========================================
Files 320 320
Lines 23531 23494 -37
Branches 3464 3446 -18
===========================================
- Hits 20289 14847 -5442
- Misses 2650 8233 +5583
+ Partials 592 414 -178 ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Dec 13, 2023
|
Congrats on merging your first pull request! 🎉 |
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
…t in flytekit (flyteorg#2022) * Add various executions phases which are available in the protobuf, but not in flytekit Signed-off-by: Maarten de Jong <mdejong@blackshark.ai> * Simplify `enum_to_string` function Signed-off-by: Maarten de Jong <mdejong@blackshark.ai> --------- Signed-off-by: Maarten de Jong <mdejong@blackshark.ai> Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
None afaik
Why are the changes needed?
So that we can access all possible phases returned by Flyte within
flytekit.Also suggesting a refactoring to
enum_to_string()in the second commit. Happy to drop that if it's deemed unnecessary.How was this patch tested?
I ran
make testlocally and it ran through. I didn't add any more tests because as much as I could find everything would fall apart already if I messed upenum_to_string(), so expecting that that is still functional after this PR :)Check all the applicable boxes