Generate version with setuptools_scm and migrate to pyproject.toml #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2028 +/- ##
==========================================
+ Coverage 85.17% 85.91% +0.73%
==========================================
Files 272 306 +34
Lines 21144 22818 +1674
Branches 3466 3466
==========================================
+ Hits 18010 19604 +1594
- Misses 2543 2622 +79
- Partials 591 592 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
eapolinario
approved these changes
Dec 8, 2023
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Dec 12, 2023
…lyteorg#2028) Signed-off-by: Future Outlier <eric901201@gmai.com>
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Dec 12, 2023
…lyteorg#2028) Signed-off-by: Future Outlier <eric901201@gmai.com>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
…lyteorg#2028) Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Remove the need for custom code to wrangle the version during release.
What changes were proposed in this pull request?
Migrate to pyproject.toml and use
setuptools_scmto generate the version based on tags. If the build is run on a commit that is also tagged, the version is the tag. For a development build, it will bump the version by+0.0.1.dev*, which has a "dev" tag at the end.For testing, you can dynamically get the generated version with
python -m setuptools_scmin the command line. For the current dev release, we have: