Fix flyin image by setting py to 3.10 #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: byhsu <byhsu@linkedin.com>
ByronHsu
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2031 +/- ##
==========================================
- Coverage 85.86% 85.81% -0.05%
==========================================
Files 306 303 -3
Lines 22848 22761 -87
Branches 3466 3470 +4
==========================================
- Hits 19619 19533 -86
+ Misses 2637 2634 -3
- Partials 592 594 +2 ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Dec 8, 2023
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Dec 12, 2023
Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com> Signed-off-by: Future Outlier <eric901201@gmai.com>
Future-Outlier
pushed a commit
to Future-Outlier/flytekit
that referenced
this pull request
Dec 12, 2023
Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com> Signed-off-by: Future Outlier <eric901201@gmai.com>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com> Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
FlyIn Image is not able to build because python version variable is empty
What changes were proposed in this pull request?
Set python version to 3.10
How was this patch tested?
local build