add monodocs ci build in flytekit #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
cosmicBboy
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2035 +/- ##
==========================================
- Coverage 85.84% 85.82% -0.03%
==========================================
Files 306 306
Lines 22897 22897
Branches 3470 3470
==========================================
- Hits 19657 19652 -5
- Misses 2645 2652 +7
+ Partials 595 593 -2 ☔ View full report in Codecov by Sentry. |
thomasjpfan
reviewed
Dec 11, 2023
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
thomasjpfan
reviewed
Dec 11, 2023
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
thomasjpfan
approved these changes
Dec 12, 2023
|
Looks like I cannot merge this one myself. Feel free to merge. |
pingsutw
approved these changes
Dec 12, 2023
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* add monodocs ci build in flytekit Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update name Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update name Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Fixes https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
With the monodocs build process in
flyteorg/flyte, we need a way of making sure upstream changes in theflytekitrepo do not break the overall build.What changes were proposed in this pull request?
Adds a github action workflow to build the docs.