Enable the flytekit to be pluggable #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
cosmicBboy
reviewed
Dec 11, 2023
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2039 +/- ##
==========================================
- Coverage 85.27% 83.87% -1.40%
==========================================
Files 274 309 +35
Lines 21360 23060 +1700
Branches 3481 3489 +8
==========================================
+ Hits 18214 19342 +1128
- Misses 2537 3095 +558
- Partials 609 623 +14 ☔ View full report in Codecov by Sentry. |
cosmicBboy
previously approved these changes
Dec 13, 2023
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
changed the title
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
commented
Dec 13, 2023
|
@cosmicBboy The monodocs failure in the CI is unrelated to this PR, but looks real. |
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
|
In 9b90029 I have pytest patch the plugin variable. This way if another plugin gets loaded, the tests still run with the first-party |
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
|
I updated the solution to #2039, which I am happy with. This allows pytest to configure the loaded plugin on demand. |
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
cosmicBboy
reviewed
Dec 14, 2023
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
pingsutw
previously approved these changes
Dec 18, 2023
eapolinario
approved these changes
Dec 19, 2023
pingsutw
approved these changes
Dec 19, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1941
Why are the changes needed?
This PR makes
pyflytepluggable by external libraries to adjust the CLI commands and update the remote.What changes were proposed in this pull request?
This PR adds a
FlytekitPluginto have the pluggable CLI API be in one place. For this initial PR, it gives the minimum API surface for configuring the API.Implementation-wise, the external plugins are loaded through entry points and have the group name:
flytekit.configuration.plugin.How was this patch tested?