Adds setuptools and wheel back in the CI for plugins #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
pingsutw
approved these changes
Dec 12, 2023
thomasjpfan
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2044 +/- ##
=======================================
Coverage 85.83% 85.84%
=======================================
Files 306 306
Lines 22914 22914
Branches 3471 3471
=======================================
+ Hits 19669 19671 +2
+ Misses 2649 2648 -1
+ Partials 596 595 -1 ☔ View full report in Codecov by Sentry. |
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deployment issue seen in https://github.com/flyteorg/flytekit/actions/runs/7186707178/job/19572701206
The plugins still require
setuptoolandwheelto be installed to build.