Inject version into the build environment #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2052 +/- ##
==========================================
- Coverage 85.98% 85.42% -0.57%
==========================================
Files 308 261 -47
Lines 22946 20841 -2105
Branches 3468 3468
==========================================
- Hits 19731 17803 -1928
+ Misses 2615 2438 -177
Partials 600 600 ☔ View full report in Codecov by Sentry. |
thomasjpfan
changed the title
eapolinario
approved these changes
Dec 14, 2023
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes version issue in https://github.com/flyteorg/flytekit/actions/runs/7187240991/job/19576949461#logs