Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Base Agent Bug #2057

Merged
merged 3 commits into from
Dec 16, 2023
Merged

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Dec 16, 2023

Tracking issue

flyteorg/flyte#3936

Why are the changes needed?

Bug fix.

What changes were proposed in this pull request?

We should input literal_map instead of a dictionary to execute the agent task locally.

How was this patch tested?

from flytekit.sensor.file_sensor import FileSensor
from flytekit import ImageSpec, task, workflow

sensor = FileSensor(name="test_sensor")

@task()
def t1():
    return

@workflow()
def wf():
    sensor(path="/tmp") >> t1()

if __name__ == "__main__":
    wf()

Setup process

Screenshots

Before
image
After
image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7f7272f) 85.98% compared to head (251cbfe) 85.98%.

Files Patch % Lines
flytekit/extend/backend/base_agent.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2057   +/-   ##
=======================================
  Coverage   85.98%   85.98%           
=======================================
  Files         308      308           
  Lines       23017    23018    +1     
  Branches     3480     3480           
=======================================
+ Hits        19792    19793    +1     
  Misses       2615     2615           
  Partials      610      610           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Future Outlier <eric901201@gmai.com>
@pingsutw pingsutw merged commit 628ac89 into flyteorg:master Dec 16, 2023
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants