unpin envd and add extra_path to imagespec
#2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2063 +/- ##
==========================================
- Coverage 86.00% 85.70% -0.31%
==========================================
Files 309 313 +4
Lines 23060 23359 +299
Branches 3489 3489
==========================================
+ Hits 19832 20019 +187
- Misses 2617 2733 +116
+ Partials 611 607 -4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
samhita-alla
changed the title
extra_path to imagespec
samhita-alla
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
pingsutw
reviewed
Dec 21, 2023
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
pingsutw
previously approved these changes
Dec 21, 2023
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
fixes flyteorg/flyte#4625
Why are the changes needed?
the working directory of the base image needs to be propagated to the image being built with imagespec.
What changes were proposed in this pull request?
this PR adds
extra_pathto imagespec. all the paths provided inextra_pathwill be appended to PATH in the image. also, not pinning the envd dependency.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link