Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling for local execution #2068

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Conversation

pingsutw
Copy link
Member

Tracking issue

NA

Why are the changes needed?

Improve error messages

What changes were proposed in this pull request?

  • Remove duplicate error message
  • Remove traceback from user_entry_point

How was this patch tested?

pyflyte run pyflyte run train_wf.py wf

Before:
image

After:
Screenshot 2023-12-22 at 3 26 44 AM

pyflyte --verbose run pyflyte run train_wf.py wf

Before:
image

image image

After:
image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw changed the title Improve error 1 Improve error handling for local execution Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (68430db) 84.81% compared to head (49f7d44) 85.65%.
Report is 2 commits behind head on master.

Files Patch % Lines
flytekit/extend/backend/base_agent.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2068      +/-   ##
==========================================
+ Coverage   84.81%   85.65%   +0.84%     
==========================================
  Files         267      309      +42     
  Lines       21068    23248    +2180     
  Branches     3491     3501      +10     
==========================================
+ Hits        17869    19914    +2045     
- Misses       2592     2726     +134     
- Partials      607      608       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw self-assigned this Dec 22, 2023
@kumare3
Copy link
Contributor

kumare3 commented Jan 2, 2024

thank you for doing this, i was about to fix this annoying thing

@pingsutw pingsutw merged commit 76ebae2 into master Jan 3, 2024
83 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants