Flyin - fix the wrong usage of context. #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: troychiu <y.troychiu@gmail.com>
troychiu
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2070 +/- ##
==========================================
+ Coverage 85.70% 85.71% +0.01%
==========================================
Files 313 313
Lines 23364 23396 +32
Branches 3489 3501 +12
==========================================
+ Hits 20025 20055 +30
Misses 2733 2733
- Partials 606 608 +2 ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Dec 26, 2023
pryce-turner
pushed a commit
that referenced
this pull request
Dec 26, 2023
Signed-off-by: troychiu <y.troychiu@gmail.com> Signed-off-by: pryce-turner <pryce.turner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the wrong usage of context.