Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized subproc_execute and added tests #2072

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

pryce-turner
Copy link
Contributor

Why are the changes needed?

subproc_execute was too restrictive, this allows passing of arbitrary kwargs with sensible defaults

What changes were proposed in this pull request?

modified subproc_execute and 2 tests for shell and non-shell exec

How was this patch tested?

2 unit tests

Signed-off-by: pryce-turner <pryce.turner@gmail.com>
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e107994) 85.71% compared to head (a667728) 85.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2072      +/-   ##
==========================================
+ Coverage   85.71%   85.73%   +0.01%     
==========================================
  Files         313      313              
  Lines       23396    23398       +2     
  Branches     3501     3501              
==========================================
+ Hits        20055    20061       +6     
+ Misses       2733     2730       -3     
+ Partials      608      607       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit d1ce05b into master Jan 2, 2024
84 checks passed
@pryce-turner pryce-turner deleted the general_subproc_exec branch January 2, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants