Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary newline in plugin README #2090

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

douenergy
Copy link
Contributor

@douenergy douenergy commented Jan 6, 2024

Tracking issue

None

Why are the changes needed?

Currently, the placement of DuckDB in the README is not consistent with the other plugins.

flyte

What changes were proposed in this pull request?

image

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

welcome bot commented Jan 6, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Signed-off-by: DouEnergy <douenergy@protonmail.com>
@douenergy
Copy link
Contributor Author

@pingsutw Please take a look 👀

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2f3b77) 85.75% compared to head (c11d507) 85.12%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2090      +/-   ##
==========================================
- Coverage   85.75%   85.12%   -0.64%     
==========================================
  Files         313      284      -29     
  Lines       23433    22089    -1344     
  Branches     3511     3511              
==========================================
- Hits        20096    18803    -1293     
+ Misses       2730     2678      -52     
- Partials      607      608       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samhita-alla samhita-alla merged commit 9c45cb2 into flyteorg:master Jan 6, 2024
83 of 84 checks passed
Copy link

welcome bot commented Jan 6, 2024

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants