Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Airflow Plugin #2099

Merged

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Jan 11, 2024

Tracking issue

Fixes flyteorg/flyte#3936

Why are the changes needed?

  • need to install the flyteidl package to ensure the airflow plugin works properly

What changes were proposed in this pull request?

  • add flyteidl package in setup.py
  • add type annotation for is_deferrable function

How was this patch tested?

pytest

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#1725

Signed-off-by: Future Outlier <eric901201@gmai.com>
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (949bc1b) 85.73% compared to head (4a33620) 85.73%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2099      +/-   ##
==========================================
- Coverage   85.73%   85.73%   -0.01%     
==========================================
  Files         313      313              
  Lines       23448    23455       +7     
  Branches     3514     3516       +2     
==========================================
+ Hits        20103    20108       +5     
- Misses       2735     2737       +2     
  Partials      610      610              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Future Outlier <eric901201@gmai.com>
@Future-Outlier Future-Outlier changed the title Fix Airflow Agent is_deferrable bug Enhance Airflow Plugin Jan 13, 2024
@pingsutw pingsutw merged commit 76f6db2 into flyteorg:master Jan 13, 2024
83 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants