Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Latest FlyteIdl in Integration Test #2105

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Jan 14, 2024

Why are the changes needed?

We should use latest FlyteIdl (include beta version) in Integration Tests

What changes were proposed in this pull request?

  • add --pre and flyteidl in Dockerfile.dev for the Integration Tests.

Alternatives

  1. change Dockerfile.dev only for passing CI tests.

How was this patch tested?

CI tests.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: Future Outlier <eric901201@gmai.com>
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (892b474) 85.77% compared to head (e78c440) 85.80%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
+ Coverage   85.77%   85.80%   +0.02%     
==========================================
  Files         313      313              
  Lines       23500    23506       +6     
  Branches     3512     3512              
==========================================
+ Hits        20158    20169      +11     
+ Misses       2734     2729       -5     
  Partials      608      608              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Future Outlier <eric901201@gmai.com>
@Future-Outlier Future-Outlier changed the title Use Latest FlyteIdl in all Dockerfile Use Latest FlyteIdl in Integration Test Jan 17, 2024
Future-Outlier added 2 commits January 17, 2024 17:12
Signed-off-by: Future-Outlier <eric901201@gmai.com>
Signed-off-by: Future-Outlier <eric901201@gmai.com>
@Future-Outlier Future-Outlier merged commit 1127206 into master Jan 17, 2024
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants