Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip errors when running pyflyte register #2111

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jan 17, 2024

Why are the changes needed?

Failed to register certain workflows due to the below errors

       "task-module",
          "basics.workflow",
          "task-name",
          "slope"
        ],
        "resources": {}
      }
    },
    "description": {
      "longDescription": {
        "format": "DESCRIPTION_FORMAT_RST"
      }
    }
  }
}
RPC Failed, with Status: StatusCode.INVALID_ARGUMENT
        details: task with different structure already exists with id resource_type:TASK project:"flytesnacks" domain:"development" name:"basics.workflow.slope" version:"v0.3.257" 
        Debug string UNKNOWN:Error received from peer  {grpc_message:"task with different structure already exists with id resource_type:TASK project:\"flytesnacks\" domain:\"development\" name:\"basics.workflow.slope\" version:\"v0.3.257\" ", grpc_status:3, created_time:"2024-01-17T00:21:33.186053-08:00"}

What changes were proposed in this pull request?

Skip errors and continue resisting the workflows

How was this patch tested?

 pyflyte register --skip-errors --version v0.3.257  basics

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: Kevin Su <pingsutw@gmail.com>
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (892b474) 85.77% compared to head (0a4619a) 85.79%.
Report is 1 commits behind head on master.

Files Patch % Lines
flytekit/tools/repo.py 27.27% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2111      +/-   ##
==========================================
+ Coverage   85.77%   85.79%   +0.01%     
==========================================
  Files         313      313              
  Lines       23500    23511      +11     
  Branches     3512     3513       +1     
==========================================
+ Hits        20158    20171      +13     
+ Misses       2734     2733       -1     
+ Partials      608      607       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw self-assigned this Jan 17, 2024
@pingsutw pingsutw merged commit 11232ab into master Jan 18, 2024
83 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants