Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit '=' from auto-generated version #2117

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

eapolinario
Copy link
Collaborator

Tracking issue

N/A

Why are the changes needed?

We've received feedback that the auto-generated versions are difficult to copy due to the extra '=' that show at the end of each version.

What changes were proposed in this pull request?

The '=' is a padding character used by the base64 algorithm to encode data, as per https://datatracker.ietf.org/doc/html/rfc4648#section-3.2. In this PR we omit those characters without loss of functionality, since those characters don't increase the entropy, while solving the original problem that a simple double-click wouldn't select those characters.

How was this patch tested?

Added one test.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aaf69f8) 84.84% compared to head (88a9b55) 62.41%.
Report is 2 commits behind head on master.

Files Patch % Lines
flytekit/remote/remote.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2117       +/-   ##
===========================================
- Coverage   84.84%   62.41%   -22.44%     
===========================================
  Files         259      313       +54     
  Lines       20756    23512     +2756     
  Branches     3512     3515        +3     
===========================================
- Hits        17611    14675     -2936     
- Misses       2537     8414     +5877     
+ Partials      608      423      -185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario merged commit 139fa2f into master Jan 19, 2024
82 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants