Include exception type in error messages #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Newton
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Tom-Newton
force-pushed
the
tomnewton/display_error_type
branch
from
6b27de0
to
aad3d53
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2130 +/- ##
=======================================
Coverage 85.78% 85.78%
=======================================
Files 313 313
Lines 23560 23560
Branches 3523 3523
=======================================
Hits 20212 20212
Misses 2738 2738
Partials 610 610 ☔ View full report in Codecov by Sentry. |
kumare3
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#4777
Why are the changes needed?
Makes it easier to debug failures.
What changes were proposed in this pull request?
Add the exception name to the error message that flytekit generates. This message gets displayed in the flyte UI.
How was this patch tested?
Updated unittests
Deployed on our flyte cluster
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link