Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly disallow iteration on Promises #2337

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Apr 10, 2024

Tracking issue

flyteorg/flyte#5164

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 10, 2024
@wild-endeavor wild-endeavor changed the title add error Explicitly disallow iteration on Promises Apr 10, 2024
eapolinario
eapolinario previously approved these changes Apr 10, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Apr 10, 2024
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.89%. Comparing base (bf38b8e) to head (3cf8d83).
Report is 4 commits behind head on master.

❗ Current head 3cf8d83 differs from pull request most recent head 646d31a. Consider uploading reports for the commit 646d31a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2337      +/-   ##
==========================================
- Coverage   83.04%   75.89%   -7.15%     
==========================================
  Files         324      180     -144     
  Lines       24861    18136    -6725     
  Branches     3547     3547              
==========================================
- Hits        20645    13765    -6880     
- Misses       3591     3777     +186     
+ Partials      625      594      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pingsutw
pingsutw previously approved these changes Apr 10, 2024
@wild-endeavor wild-endeavor dismissed stale reviews from pingsutw and eapolinario via 646d31a April 10, 2024 16:07
@wild-endeavor wild-endeavor merged commit 177571b into master Apr 10, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
3 participants