Adds typing to @task and @workflow #2411
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#3681
Why are the changes needed?
Type checkers do not work with
flytekit
right now.What changes were proposed in this pull request?
With this PR, the
@task
and@workflow
pretends to return their original types for type checking purposes. The typing in this PR is not strictly correct, because the workflow transforms everything into Promises. I think this PR is an okay solution to get typing to work for user's workflows.As for actually typing the Promises, I do not see a way to actually type them. Python typing allows us to change the output of the decorator, but we can not change the inputs:
How was this patch tested?
Run
mypy
on workflow code and see failures when types do not match:Running mypy outputs: