Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace docker-py with docker #971

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Replace docker-py with docker #971

merged 2 commits into from
Apr 22, 2022

Conversation

eapolinario
Copy link
Collaborator

@eapolinario eapolinario commented Apr 22, 2022

Signed-off-by: Eduardo Apolinario eapolinario@users.noreply.github.com

TL;DR

docker-py is the deprecated docker python sdk that got renamed to simply docker

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
wild-endeavor
wild-endeavor previously approved these changes Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #971 (4f40a9e) into master (ac6e520) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #971   +/-   ##
=======================================
  Coverage   86.26%   86.26%           
=======================================
  Files         252      252           
  Lines       24129    24129           
  Branches     2745     2745           
=======================================
  Hits        20815    20815           
  Misses       2846     2846           
  Partials      468      468           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac6e520...4f40a9e. Read the comment docs.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario merged commit 149e509 into master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants