This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fix duplicate env vars in container #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <daniel@union.ai>
…ting container Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 62.87% 62.88%
=======================================
Files 153 153
Lines 12893 12893
=======================================
+ Hits 8107 8108 +1
Misses 4172 4172
+ Partials 614 613 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Daniel Rammer <daniel@union.ai>
pingsutw
previously approved these changes
Jun 26, 2023
eapolinario
reviewed
Jun 26, 2023
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
pingsutw
approved these changes
Jun 27, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* removed duplicate execution of AddFlyteCustomizationsToContainer Signed-off-by: Daniel Rammer <daniel@union.ai> * removed duplicate call to AddFlyteCustomizationsToContainer when creating container Signed-off-by: Daniel Rammer <daniel@union.ai> * removed dead code Signed-off-by: Daniel Rammer <daniel@union.ai> * added unit test for duplicate environment variables Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Daniel Rammer <daniel@union.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Currently, when building a k8s Pod we make duplicate calls to
AddFlyteCustomizationsToContainer(here and here. This PR updates the BuildRawPod function to call a refactored BuildRawContainer to ensure theAddFlyteCustomizationsToContaineris only called once so that env vars are only injected a single time.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#3740
Follow-up issue
NA