This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Switch to official dask operator #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernhard Stadlbauer <11799671+bstadlbauer@users.noreply.github.com>
Signed-off-by: Bernhard Stadlbauer <11799671+bstadlbauer@users.noreply.github.com>
bstadlbauer
commented
Jun 27, 2023
| @@ -53,7 +52,7 @@ func getDefaults(ctx context.Context, taskCtx pluginsCore.TaskExecutionContext, | |||
| return nil, errors.Errorf(errors.BadTaskSpecification, "task is missing a default image") | |||
| } | |||
|
|
|||
| defaultEnvVars := []v1.EnvVar{} | |||
There was a problem hiding this comment.
@hamersaw I've snuck in a few mini improvements that GoLand said I could do
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
==========================================
+ Coverage 64.05% 64.07% +0.01%
==========================================
Files 152 152
Lines 10392 10392
==========================================
+ Hits 6657 6659 +2
+ Misses 3124 3122 -2
Partials 611 611
|
bstadlbauer
commented
Jun 27, 2023
| github.com/coocood/freecache v1.1.1 | ||
| github.com/dask/dask-kubernetes/v2023 v2023.0.0-20230626103304-abd02cd17b26 |
There was a problem hiding this comment.
I think this is due to dask-kubernetes not prefixing their tags with a v (i.e. 2023.6.0 vs. v2023.6.0)
hamersaw
approved these changes
Jun 27, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Switch to using official `dask` plugin Signed-off-by: Bernhard Stadlbauer <11799671+bstadlbauer@users.noreply.github.com> * Fix small code nits Signed-off-by: Bernhard Stadlbauer <11799671+bstadlbauer@users.noreply.github.com> --------- Signed-off-by: Bernhard Stadlbauer <11799671+bstadlbauer@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This replaces the
godaskclient fromgithub.com/bstadlbauer/dask-k8s-operator-go-clientwith the official one fromgithub.com/dask/dask-kubernetes/v2023.The operator has been moved over from my repo to the official one in dask/dask-kubernetes#731, so the code is essentially the same, but I'm going ahead and will archive my version.
Type