Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Remove welcomebot from boilerplate #375

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

eapolinario
Copy link
Contributor

Read then delete this section

- Make sure to use a concise title for the pull-request.

- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#1963

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #375 (c758296) into master (7ddd993) will increase coverage by 1.34%.
The diff coverage is n/a.

❗ Current head c758296 differs from pull request most recent head 9f7aedd. Consider uploading reports for the commit 9f7aedd to get more accurate results

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
+ Coverage   62.89%   64.23%   +1.34%     
==========================================
  Files         154      154              
  Lines       13029    10570    -2459     
==========================================
- Hits         8195     6790    -1405     
+ Misses       4221     3167    -1054     
  Partials      613      613              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 135 files with indirect coverage changes

@eapolinario eapolinario merged commit 4e5ff42 into master Jul 17, 2023
7 checks passed
eapolinario added a commit that referenced this pull request Sep 6, 2023
Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: eduardo apolinario <eapolinario@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant