Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Use agent as name where it fits #381

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

honnix
Copy link
Member

@honnix honnix commented Aug 2, 2023

TL;DR

Use agent as name where it fits

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

This is some leftover of #368 where we should have aligned the naming better. Note that this PR has no breaking change.

Tracking Issue

flyteorg/flyte#3823

Follow-up issue

NA

Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
@honnix honnix requested a review from pingsutw August 2, 2023 09:19
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #381 (f95d6fc) into master (22d2635) will increase coverage by 1.34%.
The diff coverage is 73.33%.

❗ Current head f95d6fc differs from pull request most recent head 6a87399. Consider uploading reports for the commit 6a87399 to get more accurate results

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   63.01%   64.36%   +1.34%     
==========================================
  Files         154      154              
  Lines       13071    10605    -2466     
==========================================
- Hits         8237     6826    -1411     
+ Misses       4218     3163    -1055     
  Partials      616      616              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
go/tasks/plugins/webapi/agent/plugin.go 71.14% <73.33%> (+3.00%) ⬆️

... and 134 files with indirect coverage changes

@honnix
Copy link
Member Author

honnix commented Aug 2, 2023

@pingsutw Wanna merge this?

@pingsutw pingsutw merged commit 98d66e0 into flyteorg:master Aug 2, 2023
7 checks passed
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants