fix: strip outputs + test

Signed-off-by: Kenny Workman <kennyworkman@sbcglobal.net>

pkg/compiler/transformers/k8s/node.go

@@ -223,14 +223,26 @@ func buildTasks(tasks []*core.CompiledTask, errs errors.CompileErrors) map[commo
 
 			// We don't want Annotation data available at task runtime for performance.
 			if flyteTask.Template != nil &&
-				flyteTask.Template.Interface != nil &&
-				flyteTask.Template.Interface.Inputs != nil &&
-				flyteTask.Template.Interface.Inputs.Variables != nil {
-				for _, v := range flyteTask.Template.Interface.Inputs.Variables {
-					if v.Type != nil && v.Type.Annotation != nil {
-						v.Type.Annotation = nil
+				flyteTask.Template.Interface != nil {
+
+				if flyteTask.Template.Interface.Inputs != nil &&
+					flyteTask.Template.Interface.Inputs.Variables != nil {
+					for _, v := range flyteTask.Template.Interface.Inputs.Variables {
+						if v.Type != nil && v.Type.Annotation != nil {
+							v.Type.Annotation = nil
+						}
 					}
 				}
+
+				if flyteTask.Template.Interface.Outputs != nil &&
+					flyteTask.Template.Interface.Outputs.Variables != nil {
+					for _, v := range flyteTask.Template.Interface.Outputs.Variables {
+						if v.Type != nil && v.Type.Annotation != nil {
+							v.Type.Annotation = nil
+						}
+					}
+				}
+
 			}
 
 			res[taskID] = &v1alpha1.TaskSpec{TaskTemplate: flyteTask.Template}

pkg/compiler/transformers/k8s/node_test.go

@@ -234,7 +234,7 @@ func TestBuildTasks(t *testing.T) {
 	tasks := []*core.CompiledTask{
 		{
 			Template: &core.TaskTemplate{
-				Id: &core.Identifier{Name: "annotated"},
+				Id: &core.Identifier{Name: "annotatedInput"},
 				Interface: &core.TypedInterface{
 					Inputs: &core.VariableMap{
 						Variables: withAnnotations,
@@ -244,25 +244,51 @@ func TestBuildTasks(t *testing.T) {
 		},
 		{
 			Template: &core.TaskTemplate{
-				Id: &core.Identifier{Name: "unannotated"},
+				Id: &core.Identifier{Name: "unannotatedInput"},
 				Interface: &core.TypedInterface{
 					Inputs: &core.VariableMap{
 						Variables: withoutAnnotations,
 					},
 				},
 			},
 		},
+		{
+			Template: &core.TaskTemplate{
+				Id: &core.Identifier{Name: "annotatedOutput"},
+				Interface: &core.TypedInterface{
+					Outputs: &core.VariableMap{
+						Variables: withAnnotations,
+					},
+				},
+			},
+		},
+		{
+			Template: &core.TaskTemplate{
+				Id: &core.Identifier{Name: "unannotatedOutput"},
+				Interface: &core.TypedInterface{
+					Outputs: &core.VariableMap{
+						Variables: withoutAnnotations,
+					},
+				},
+			},
+		},
 	}
 
 	errs := errors.NewCompileErrors()
 
 	t.Run("Tasks with annotations", func(t *testing.T) {
 		taskMap := buildTasks(tasks, errs)
 
-		annTask := taskMap[(&core.Identifier{Name: "annotated"}).String()]
-		assert.Nil(t, annTask.Interface.Inputs.Variables["a"].Type.Annotation)
+		annInputTask := taskMap[(&core.Identifier{Name: "annotatedInput"}).String()]
+		assert.Nil(t, annInputTask.Interface.Inputs.Variables["a"].Type.Annotation)
+
+		unAnnInputTask := taskMap[(&core.Identifier{Name: "unannotatedInput"}).String()]
+		assert.Nil(t, unAnnInputTask.Interface.Inputs.Variables["a"].Type.Annotation)
+
+		annOutputTask := taskMap[(&core.Identifier{Name: "annotatedOutput"}).String()]
+		assert.Nil(t, annOutputTask.Interface.Outputs.Variables["a"].Type.Annotation)
 
-		unAnnTask := taskMap[(&core.Identifier{Name: "annotated"}).String()]
-		assert.Nil(t, unAnnTask.Interface.Inputs.Variables["a"].Type.Annotation)
+		unAnnOutputTask := taskMap[(&core.Identifier{Name: "unannotatedOutput"}).String()]
+		assert.Nil(t, unAnnOutputTask.Interface.Outputs.Variables["a"].Type.Annotation)
 	})
 }