This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Use GetExecutionData instead #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
katrogan
previously approved these changes
Jun 12, 2023
| @@ -246,12 +247,30 @@ func (a *adminLaunchPlanExecutor) syncItem(ctx context.Context, batch cache.Batc | |||
| continue | |||
| } | |||
|
|
|||
| execData, err := a.adminClient.GetExecutionData(ctx, &admin.WorkflowExecutionGetDataRequest{ | |||
There was a problem hiding this comment.
For performance reasons, would it be worthwhile to wrap this call in an if block and only fetch execution data when RawOutputPolicy is set to inline?
There was a problem hiding this comment.
Discussed offline. We always need to call GetExecutionData()
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
…nto sub-lp-outputs
katrogan
approved these changes
Jun 13, 2023
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Use GetExecutionData instead Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * bump Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * fix unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * more fixes Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * fix more Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Regenerate Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Only call GetExecutionData when the workflow succeeds Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> --------- Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Removes deprecated code path to retrieve LP's outputs and moves to the separate GetExecutionData() call.
Type
Are all requirements met?
Tracking Issue
fixes flyteorg/flyte#3753