Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Supporting using arraynode as a subnode #606

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Conversation

hamersaw
Copy link
Contributor

TL;DR

Correctly setting the parent node execution ID of the ArrayNode TaskExecutionEvent messages to support executing as a subnode (ie. with dynamic tasks / subworkflows / branch nodes).

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #606 (641636e) into master (476d416) will increase coverage by 0.43%.
The diff coverage is 66.66%.

❗ Current head 641636e differs from pull request most recent head bc72969. Consider uploading reports for the commit bc72969 to get more accurate results

Additional details and impacted files

Signed-off-by: Daniel Rammer <daniel@union.ai>
@hamersaw hamersaw marked this pull request as ready for review September 1, 2023 17:12
@hamersaw hamersaw merged commit 738703a into master Sep 7, 2023
14 checks passed
@hamersaw hamersaw deleted the bug/array-node-with-parent branch September 7, 2023 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants