This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add supportTaskTypes for agentservice without write it in config twice. #612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
As title.
Note: Please merge the code below, so that the code will work!
flyteorg/flyteplugins#398
Type
Are all requirements met?
Complete description
Right now, the agent-service section doesn't need to add supportedTaskTypes anymore.
![image](https://private-user-images.githubusercontent.com/76461262/265200568-5e603439-5b15-4fdb-b872-7896ed5e745c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1MjI2NjEsIm5iZiI6MTcyMDUyMjM2MSwicGF0aCI6Ii83NjQ2MTI2Mi8yNjUyMDA1NjgtNWU2MDM0MzktNWIxNS00ZmRiLWI4NzItNzg5NmVkNWU3NDVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA5VDEwNTI0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZkMGUzNTRiNmZlZjczMTM3ZmI1ZjFlZTRiZWY3NDFhYTYwZWQyYzMxMDJjY2U1OWY3YTAxOWM2YzZiMGFhM2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kxHRec27acoGVWe1kdZwYGWTCvOu_AOCeHfpEYeYdTc)
![image](https://private-user-images.githubusercontent.com/76461262/265200579-3071fb34-9db0-4131-aabb-633f52ff00e2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1MjI2NjEsIm5iZiI6MTcyMDUyMjM2MSwicGF0aCI6Ii83NjQ2MTI2Mi8yNjUyMDA1NzktMzA3MWZiMzQtOWRiMC00MTMxLWFhYmItNjMzZjUyZmYwMGUyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA5VDEwNTI0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJkZjc1ZjQ4OTg2YjMwNDFhNmVmZTZmZmQ1ZDk3NWJjZGExNzA5MjIzMjFmYjQ3Yzk4ZjU4ZjkwOTIwZWZmNjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.EKVHDCTvRU4_FlzVCg6oknA2K2zPHHsKkGmixY10ALM)
We can get it by "default-for-task-types" from tasks.
Tracking Issue
flyteorg/flyteplugins#398