Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Bump flytestdlib version #619

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Bump flytestdlib version #619

merged 6 commits into from
Sep 19, 2023

Conversation

pingsutw
Copy link
Member

TL;DR

This is the follow-up issue for flyteorg/flytestdlib#164

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #619 (cdb4778) into master (9aec46d) will increase coverage by 0.44%.
Report is 1 commits behind head on master.
The diff coverage is 60.00%.

❗ Current head cdb4778 differs from pull request most recent head 1416c3e. Consider uploading reports for the commit 1416c3e to get more accurate results

Additional details and impacted files

Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 but have dan look at this too.

we've updated all implementations of the interface that changed right?

@pingsutw pingsutw merged commit 6b1d11c into master Sep 19, 2023
14 checks passed
@pingsutw pingsutw deleted the update-stdlib branch September 19, 2023 21:06
@pingsutw
Copy link
Member Author

pingsutw commented Sep 19, 2023

yes, otherwise, compilation will fail.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants