Updates Spark dockerfile #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
kumare3
reviewed
Oct 25, 2022
| ENV SPARK_VERSION 3.2.1 | ||
| ENV PYSPARK_PYTHON ${VENV}/bin/python3 | ||
| ENV PYSPARK_DRIVER_PYTHON ${VENV}/bin/python3 | ||
|
|
||
| # Copy the makefile targets to expose on the container. This makes it easier to register. | ||
| # Delete this after we update CI | ||
| COPY in_container.mk /root/Makefile |
There was a problem hiding this comment.
When can we get rid of this stuff
There was a problem hiding this comment.
EngHabu
previously approved these changes
Oct 25, 2022
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
EngHabu
approved these changes
Dec 12, 2022
Comment on lines
+36
to
+37
| RUN wget https://repo1.maven.org/maven2/org/apache/hadoop/hadoop-aws/3.2.2/hadoop-aws-3.2.2.jar -P /opt/spark/jars && \ | ||
| wget https://repo1.maven.org/maven2/com/amazonaws/aws-java-sdk-bundle/1.11.563/aws-java-sdk-bundle-1.11.563.jar -P /opt/spark/jars |
There was a problem hiding this comment.
Why do we need this? I thought we managed to make it work without further customizations, did we not?
There was a problem hiding this comment.
This is required if say, a spark dataframe needs to be passed between the Flyte tasks. If these libraries aren't installed, we'll be receiving UnsupportedFileSystemException: No FileSystem for scheme "s3" error. These libraries are required to read from or write to s3 in a spark setup.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samhita Alla aallasamhita@gmail.com