Flyway "(unsupported protocol: war)" with Tomcat 8.0.41 and unpackWARs=false

[thomasmey]

Hi,

this Tomcat commit apache/tomcat80@7e767cc#diff-a72fb99b0729353084d2c437f749e718 broke Flyway in

flyway/flyway-core/src/main/java/org/flywaydb/core/internal/util/scanner/classpath/ClassPathScanner.java

Line 310 in 7925112

if ("jar".equals(protocol)

with Tomcat config unpackWARs=false.
The returned URL is now war: instead of jar:

[thomasmey]

The fix from #1512 is incomplete as the JarFileClassPathLocationScanner will get used for protocol "war" but the protocol separator is then "*/" and not "!/", so getJarFromUrl() will fail to correctly determine the file name.

This whole code fragment looks very similar to https://github.com/spring-projects/spring-framework/blob/master/spring-core/src/main/java/org/springframework/core/io/support/PathMatchingResourcePatternResolver.java#L578 which has a similar bug reported in https://jira.spring.io/browse/SPR-15332

[axelfontaine]

Arrgghh!! OK, we'll have to adjust for this.

[axelfontaine]

Thanks for the PR! Merged.