Fix issues #116 #117
Merged
Fix issues #116 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changed to 1 and avoid changing 100..xxx to 101..xxx
fmalmeida
deleted the
116-integron_finder_2gff-terminated-with-an-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a quick patch release, thus pointed directly to master, to solve issue #116 where
integron_finderwould sometimes generate genbank files where items start in position 0.However, position 0 is not allowed by the perl gbk2gff converter and thus, a small
sedoperation was added to modify these values to 1, when happening, before the conversion.Code was tested by reporter user and thus, it can be merged when all small checkings are done.