Fix issues related to listings #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found that this PR does not work with the listings package. I will try to fix it. |
pi8027
changed the title
pi8027
force-pushed
the
widelisting
branch
2 times, most recently
from
272c0f0
to
2bc66d8
Compare
|
Hi, thanks! What's the state of this PR, after closing #235? |
|
Sorry. I still need some more time to properly redo this PR. |
pi8027
commented
Sep 27, 2022
|
Almost there! I still have to do something with TOC (List of Listings), which is not very clear to me at the moment. The first commit, which properly fixes the sparing issue in |
|
Done. |
alxvth
added a commit
to alxvth/kaobook
that referenced
this pull request
May 4, 2024
fmarotta#257 (Add the wide algorithm* environment and make its caption style consistent with kaobook) fmarotta#225 (Fix issues related to listings) fmarotta#223 (Fixing figure caption)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new class option
listing=(listings|minted)and fixes #236. Now,kao.styrequires eitherlistings.styorminted.stydepending on the users' choice. Themarginlistingenvironment supports only the chosen package.listings:marginlisting. This is done by supplyingformat=marginto\captionsetup.lstlistingenvironment yet.minted:listing*environment.\c@listingwithin chapter.Other changes:
marginlistingis redone usinglabelsep=colon, but thenumbers=enddotclass option is not properly supported.\floatsetupdeclarations are refactored.