Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API improvements to open and close files #4

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

fmartingr
Copy link
Owner

@fmartingr fmartingr commented Sep 26, 2023

Different io methods: Read/Save (from string path), Open/Write (from io.Reader/io.Writer).

@codecov-commenter
Copy link

Codecov Report

Merging #4 (294bd4c) into latest (1d670dd) will decrease coverage by 1.03%.
The diff coverage is 56.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           latest       #4      +/-   ##
==========================================
- Coverage   50.00%   48.97%   -1.03%     
==========================================
  Files           2        2              
  Lines          32       49      +17     
==========================================
+ Hits           16       24       +8     
- Misses         12       18       +6     
- Partials        4        7       +3     
Files Coverage Δ
schema.go 63.63% <100.00%> (ø)
io.go 44.73% <52.17%> (+1.87%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmartingr fmartingr changed the title #WIP API Improvements feat: API improvements to open and close files Sep 26, 2023
@fmartingr fmartingr merged commit e9873f7 into latest Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants