Fix wrong value retained after a period of consumption stability

fmartinou · Oct 24, 2022 · a64090c · a64090c
1 parent 7664d75
commit a64090c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/app/teleinfo/TicMode.js b/app/teleinfo/TicMode.js
@@ -21,6 +21,7 @@ class TicMode {
         this.currentFrame = {};
         this.eventEmitter = new EventEmitter();
         this.lastEmitTime = Date.now();
+        this.lastFrameSent = {};
 
         // Graceful exit
         process.on('SIGTERM', () => this.disconnect());
@@ -122,6 +123,7 @@ class TicMode {
                     log.debug(`Dispatch frame ${JSON.stringify(this.currentFrame)}`);
                     this.eventEmitter.emit('frame', this.currentFrame);
                     this.lastEmitTime = currentTime;
+                    this.lastFrameSent = this.currentFrame;
                 } else {
                     log.debug(`Ignoring MQTT emission because of emit interval (Emit interval : ${emitInterval} - Last emit time : ${this.lastEmitTime} - Current time : ${currentTime}`);
                 }
@@ -237,7 +239,7 @@ class TicMode {
      * @return {*|boolean}
      */
     isSameFrame() {
-        return deepEqual(this.currentFrame, this.previousFrame);
+        return deepEqual(this.currentFrame, this.lastFrameSent);
     }
 
     /**

diff --git a/app/teleinfo/TicMode.test.js b/app/teleinfo/TicMode.test.js
@@ -162,7 +162,7 @@ test('processData should not publish event when frame date is under emit interva
 test('processData should not publish event when frame is identical', async () => {
     const ticMode = new TicMode();
     jest.spyOn(ticMode.eventEmitter, 'emit').mockImplementation(() => {});
-    ticMode.previousFrame = {
+    ticMode.lastFrameSent = {
         IDENTICAL: 'IDENTICAL',
     };
     ticMode.currentFrame = {
@@ -202,7 +202,7 @@ test('processData should reset frame when frame starts', async () => {
 
 test('isSameFrame should return true when frame is same as previous one', () => {
     const ticMode = new TicMode();
-    ticMode.previousFrame = {
+    ticMode.lastFrameSent = {
         ADCO: {
             raw: '12345678901',
             value: 12345678901,
@@ -283,7 +283,7 @@ test('isSameFrame should return true when frame is same as previous one', () =>
 
 test('isSameFrame should return true when frame is same as previous one but keys shuffled', async () => {
     const ticMode = new TicMode();
-    ticMode.previousFrame = {
+    ticMode.lastFrameSent = {
         OPTARIF: {
             raw: 'HC..',
             value: 'HC',

diff --git a/docs/changelog/README.md b/docs/changelog/README.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## dev
+- :fire: Fix wrong value retained after a period of consumption stability
+
 ## 8.1.3
 - :fire: Rollback "Fix home-assistant configuration not republished when the MQTT broker is restarted (without retain option)"