Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy deprecation warnings #195

Merged
merged 4 commits into from
Feb 23, 2021

Conversation

TimoRoth
Copy link
Contributor

Same as with OGGM, it might be worth to review if some of those np.int should be replace with int32/64 instead.

@TimoRoth TimoRoth force-pushed the fix_deprecation_warnings branch 3 times, most recently from 91de4a0 to 790052e Compare February 22, 2021 21:50
@TimoRoth
Copy link
Contributor Author

TimoRoth commented Feb 23, 2021

I don't know why that one test is failing. My understanding is, that np.float/np.int are just aliases for float and int, so changing it should not have ANY side effects.
I tried changing it to np.float_ and np.int_ instead, but that produces a whole lot of other failures.

Edit: Looks like the reason is the -rc test environment pulling in a really old version of Pandas.
The -rc one pulls pandas-1.0.0rc0, while the non-rc gets pandas-1.2.2. A bit weird, given that the goal of it probably is to test more recent versions.

@fmaussion
Copy link
Owner

Thanks a lot!!! That's awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants