Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getGenomicTiles #54

Merged
merged 9 commits into from
Feb 8, 2021
Merged

add getGenomicTiles #54

merged 9 commits into from
Feb 8, 2021

Conversation

mbstadler
Copy link
Collaborator

On GHA, it currently fails checks because Gviz and SingleR do not seem available, even though remotes::dev_package_deps detects them correctly as required.

My guess is that for some reason, their installation is currently failing. I am not sure what we can do here, other than give it a day and try again.

@mbstadler
Copy link
Collaborator Author

mbstadler commented Feb 1, 2021

Thanks Charlotte for identifying the issue of the failed GHA build!
I am adding it here for future reference: DelayedMatrixStats currently fails to install: http://bioconductor.org/checkResults/release/bioc-LATEST/DelayedMatrixStats/

There is already an issue: PeteHaitch/DelayedMatrixStats#73

R/getGenomicTiles.R Outdated Show resolved Hide resolved
R/getGenomicTiles.R Outdated Show resolved Hide resolved
R/getGenomicTiles.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@csoneson csoneson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice! Just a few thoughts inline.

R/getGenomicTiles.R Show resolved Hide resolved
R/getGenomicTiles.R Show resolved Hide resolved
R/getGenomicTiles.R Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #54 (9b4ddd8) into master (967621b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   99.53%   99.58%   +0.04%     
==========================================
  Files          14       15       +1     
  Lines         865      965     +100     
==========================================
+ Hits          861      961     +100     
  Misses          4        4              
Impacted Files Coverage Δ
R/getGenomicTiles.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967621b...9b4ddd8. Read the comment docs.

@mbstadler mbstadler merged commit b4498f4 into master Feb 8, 2021
@mbstadler mbstadler deleted the tiles branch February 8, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants