Another small fix for ack #66
Conversation
|
Can you change the commit message so it is clear at first glance what this does? (If not possible, I'll do it myself). Looks good otherwise. |
|
Sure -- to be certain, the original intention was to not search through `.', right? (so searching through, say .mydotfile is intended behaviour?) |
|
The original intention was to not search through hidden files, yes. (It shouldn't search in |
|
Ah, okay, this fix will still search through those files. |
|
Maybe that should be optional behavior. I don't see the point in searching through hidden files in a directory full of notes, though. It can also mess things up with VCS stuff. |
Non-anchored version will skip files that have a . in their name.
|
The current behaviour (no dotfiles at all) makes sense IMO; it was just skipping all files with a dot anywhere in their name previously! Fixed up the commit; I had my anchor wrong so who knows why it was even working before. Should be good to go now. |
|
Looks good. Thanks for the patch, it's really appreciated. |
|
No worries -- it's somewhat out of necessity; I just got a mac and unfortunately the default grep is a PoS so I'm stuck with ack! |
|
I like ag much better, I remember ack was the slowest of the "next gen" grep tools (slower than grep, even). But that was a while ago. |
Was the intention to exclude searching through
.? If so ack doesn't search this by default, but just in case I added a $ to the start since the search had the unintended side effect of skipping all files with a dot in their name.