Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make is_range public API, fix #751 #759

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Make is_range public API, fix #751 #759

merged 1 commit into from
Jun 6, 2018

Conversation

drrlvn
Copy link
Contributor

@drrlvn drrlvn commented Jun 5, 2018

No description provided.

@drrlvn drrlvn mentioned this pull request Jun 5, 2018
Closed
@Remotion
Copy link
Contributor

Remotion commented Jun 6, 2018

It would be consistent to move is_tuple_like<> to fmt namespace too.

@drrlvn
Copy link
Contributor Author

drrlvn commented Jun 6, 2018

@Remotion what about is_like_std_string, should I move that to fmt as well?

@drrlvn
Copy link
Contributor Author

drrlvn commented Jun 6, 2018

Moved is_tuple_like as well.

@Remotion
Copy link
Contributor

Remotion commented Jun 6, 2018 •
edited
Loading

Then may be it was not great idea to do this in this PR as well ?
#763

what about is_like_std_string, should I move that to fmt as well?

I think yes.

@drrlvn
Copy link
Contributor Author

drrlvn commented Jun 6, 2018

I think yes.

Actually looking at it again it looks to only be used in is_range so I don't see much value in moving is_like_std_string as well.

@vitaut vitaut merged commit cd5b567 into fmtlib:master Jun 6, 2018
@vitaut
Copy link
Contributor

vitaut commented Jun 6, 2018

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drrlvn @Remotion @vitaut