Choose best value type inplementation #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #87 (it was choosing the wrong function. The process for choosing the appropriate constructor / builder function would just choose the first one it found that matched the the set of property keywords. ui/color and presumably others have more than one such function. This PR will i the best constructor available by using a score multimethod that give preference to the constructor / builder that best matches the given args. Right now that is just giving preference to matching clojure Longs with other integer types and Doubles with other float types. This can easily be extended by adding more 'score' multimethods as the need arises.